MugishoMp / obsidian-editor-width-slider

With this plugin you can set the line width of the editor in obsidian.
MIT License
45 stars 4 forks source link

Does not work with the "Minimal" theme #6

Open GarrettKaupp opened 1 year ago

GarrettKaupp commented 1 year ago

The slider has no effect when I'm using the popular "Minimal" theme. I suspect its a problem with the theme, but if there is a way to supersede the setting with this plugin it would be awesome.

Asthestarsfalll commented 1 year ago

I encountered the same problem

ggHoek commented 1 year ago

Same here!

MugishoMp commented 1 year ago

Hey, sorry for the late reply. I havent had the time to look into it but ill see what i can do this weekend. I haven't used the minimal theme before so Ill try that out and see if I can find whatever is causing for problems. Thank you for your patience.

narze commented 1 year ago

FYI: Minimal theme has its own settings for width and it has multiple width values as attached

image
yarub123 commented 6 months ago

@narze Hey man, just curious what font is that in your image? It reminds me of Iosevka, I'm just curious because I feel like it's on the tip of my tongue lool.

globmont commented 5 months ago

I think I found a solution (working on my local Obsidian instance). It looks like while the plugin currently adjusts the --file-line-width SASS variable, the Minimal theme uses the --line-width SASS variable.

I've opened a PR (#15) to support the Minimal theme. Would appreciate a review when you get a chance @MugishoMp. Thanks!