MuhametSmaili / note-it

OCR functionality in a feature-rich note-taking extension.
Apache License 2.0
97 stars 4 forks source link

fix: remove the created div within render function #75

Closed MuhametSmaili closed 2 years ago

MuhametSmaili commented 2 years ago

📚 Summary

In the render function, we have added a class h-screen for always taking the full available height. 👇 https://github.com/MuhametSmaili/note-it/blob/76091d025277078fb99c28c073f31ea511efe040/src/utils/render.ts#L4

This is not the best approach and also it breaks when we inject script because it creates a new div with the entire available space at the bottom of the website.

Keep in mind, that the h-screen has been added for responsiveness of the dashboard inside popup.html, so the dashboard always takes up the entire available space.

MuhametSmaili commented 2 years ago

:tada: This issue has been resolved in version 1.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: