MuhametSmaili / note-it

OCR functionality in a feature-rich note-taking extension.
Apache License 2.0
97 stars 4 forks source link

OCR Issue... [BUG] #97

Open PhoenixEugene opened 1 year ago

PhoenixEugene commented 1 year ago

Hello there. I really love your extension, it's by far the best-looking notes app out there. That's why I thought I'd submit this report in hopes that the extension is still supported and maintained. Now to the issue: the OCR feature is just not working for me.

I'll provide some screenshots but the gist of the issue is, neither "upload image" nor clicking the camera icon on the top right corner, selecting an area, and clicking "convert to text" are working.

The "upload image" method just does nothing. I click it and nothing happens. The "convert to text" method just keeps on loading forever and nothing happens there either. Doesn't matter how much text there is in a picture. Could be a paragraph or 2 words. It loads forever for both. (Note: the "upload image" doesn't work even when I use 'open in window', same as 'copy from clipboard'. It just keeps loading and loading...)

Screenshots: Screenshot-20230603191457 2023-06-03 19_53_50-Greenshot

Thank you in advance. Hopefully, you guys are still working on this wonderful extension. (Side note: would it be possible to have a dark theme implemented?)

MuhametSmaili commented 1 year ago

Sorry for the late reply, I missed the issue/notification. And thanks for the kind words.

I still use the extension and I will maintain no worries. When I am testing on Chrome it works fine for both the screenshot and also the uploaded image.

I will check out the issue in more detail this weekend.

:book: NOTE

The uploaded image works only in window mode (separate window). Also, you can see that we added a new feature to the OCR TAB -> Paste image from clipboard.

image

This helps in case you screenshot with your builtin screenshot or you have copied an image, you can just paste the image and convert it to text, also same unfortunately this feature works only in window mode

I do not have Brave installed on my pc but I will install and test it out this weekend.

What I can suggest checking is:

When you copy the image and press convert to text, most browsers now will ask for permission to read the clipboard, usually it will show a popup or no popup just you will see at the end of the URL the clipboard icon with a red x, press it and allow permission.

This permission is needed to write the OCR-ed text to your clipboard.

Same case on the window mode. If the permission is off the extension will not be able to write your text to the clipboard.

Check this image for more details: image

image

Can you confirm after you check this @PhoenixEugene ?

Thanks in advance

PhoenixEugene commented 1 year ago

@MuhametSmaili Thank you so much for taking the time to write such a thorough explanation. Unfortunately, I still can't seem to get the OCR feature to work. Since there's no bug and it seems to be working fine for you on Chrome, right now I'm 70% convinced it might be an issue with Brave itself... or me.

To address the browser permission point; I have not once been asked for permission to read the clipboard on any of the websites I tried. Never got any popup or a clipboard icon in the address bar either. I have to point out that now instead of the "paste image from clipboard" option loading indefinitely, it now gives me an "error, try again" message. (PS: The cropped image/convert to text option still loads forever)

2023-06-13 23_16_45

With all of that being said, for me personally, this isn't at all a dealbreaker. I don't use the OCR that often and the main thing for me is the notes feature, which I love immensely. So, again, thanks for making such a wonderful extension, and don't worry about this OCR issue thing. It might very well be not working because I'm doing something wrong or I'm missing something crucial. Maybe it's caused by a conflict with another extension or as I said before, the issue is with the browser itself. Whatever the issue may be, the OCR working perfectly isn't a prerequisite for me to continue using the extension.

MuhametSmaili commented 1 year ago

@PhoenixEugene I will try to debug and check more thoroughly. since I do not have Brave I cannot suggest anything more but I will install it and check it out, and come back to you.

Also, one thing to note, since you have mentioned dark mode, here is a first look into it:

image

We will be working on it too.

PhoenixEugene commented 1 year ago

@MuhametSmaili Whoa! That looks beautiful! I can't wait. Thank you so much!