MuhammedKalkan / OpenLens

OpenLens Binary Build Repository
4.04k stars 271 forks source link

Mac app is not trusted #1

Closed janhoy closed 2 years ago

janhoy commented 2 years ago

The mac .dmg package can easily be installed by dropping the app into /Applications, but then most users won't be able to run it due to lack of trusted signature. Is there a way for the GitHub action to pick up some credential for a Mac developer during build?

MuhammedKalkan commented 2 years ago

It seems it is possible to produce a signed package, however someone needs to arrange certificates with developer account. Example : https://localazy.com/blog/how-to-automatically-sign-macos-apps-using-github-actions

janhoy commented 2 years ago

Do you have a Mac? If not, I could probably help with the cert.

MuhammedKalkan commented 2 years ago

Problem seems to be the developer account. i dont have one. İf you have one , i think it is more convenient to create a dev installer certificate for .dmg ones. Not really experienced with mac cert processes.

janhoy commented 2 years ago

I have an Apple dev account, currently investigating the steps involved. If you are willing to grant me maintainer access to this repo, I can try to add my certificate as a github secret and test the flow in a new branch.

MuhammedKalkan commented 2 years ago

Sure, check inv

Punkoivan commented 2 years ago

That would be awesome. Thanks for your initiative folks.

jkroepke commented 2 years ago

@MuhammedKalkan I can also provide a signature through @xavierLowmiller apple developer Account. Good point to move forward here since its blocking the M1 builds here.

MuhammedKalkan commented 2 years ago

@MuhammedKalkan I can also provide a signature through @xavierLowmiller apple developer Account. Good point to move forward here since its blocking the M1 builds here.

That would be the fastest solution right now.On top of signing also notarization needs to take place. @janhoy tried the same approach but could not see it through i guess. if you can make a PR after signing and confirming, we can merge back here

jkroepke commented 2 years ago

@MuhammedKalkan PR opened. binaries can be tested.