MuhammedKalkan / OpenLens

OpenLens Binary Build Repository
4.07k stars 272 forks source link

try dif node #146

Closed MuhammedKalkan closed 1 year ago

jkroepke commented 1 year ago

@MuhammedKalkan seems like they revamp the build process.

To handle #145, read https://www.electronjs.org/de/docs/latest/tutorial/using-native-node-modules. Normally, this is done by electron-rebuilder, however automatic rebuild is disabled.

https://github.com/lensapp/lens/blob/5432259e052ff587752203af684bcc527d7cd4bd/open-lens/package.json#L85

I would not reenable the rebuild process, because its part of the postinstall script. Looking at https://github.com/lensapp/lens/pull/7115, they switch from yarn back to npm. It seems like we have to replicate the steps to get an working build back. I will some efforts on a branch

MuhammedKalkan commented 1 year ago

Hm local builds are working for macos, also windows binaries on github are also working, all built by same commands