MuhammedKalkan / OpenLens

OpenLens Binary Build Repository
4.04k stars 271 forks source link

Enable Apple amd64 builds #15

Closed jkroepke closed 2 years ago

jkroepke commented 2 years ago

This is an alternative to #14

I verified this by running ELECTRON_BUILDER_EXTRA_ARGS="--arm64 --x64" make clean build on my intel Mac and copied the arm64 build to my M1 Mac. On M1, I tested OpenLens with a local minikube.

Building x64 and arm64 on together is required to generate a bundled latest-mac.yaml file. (https://github.com/electron-userland/electron-builder/issues/5592#issuecomment-770057575)

Build times are still fine:

yarn run electron-builder --publish onTag --arm64 --x64
yarn run v1.22.19
$ /Users/jkr/Downloads/lens/node_modules/.bin/electron-builder --publish onTag --arm64 --x64
  • electron-builder  version=23.1.0 os=21.6.0
  • loaded configuration  file=package.json ("build" field)
  • writing effective config  file=dist/builder-effective-config.yaml
  • rebuilding native dependencies  dependencies=node-pty@0.10.1 platform=darwin arch=x64
  • rebuilding native dependency  name=node-pty version=0.10.1
  • packaging       platform=darwin arch=x64 electron=15.5.7 appOutDir=dist/mac
  • file source doesn't exist  from=/Users/jkr/Downloads/lens/locales
  • skipped macOS application code signing  reason=cannot find valid "Developer ID Application" identity or custom non-Apple code signing certificate, it could cause some undefined behaviour, e.g. macOS localized description not visible, see https://electron.build/code-signing allIdentities=  1) DB18FD789312661372C9CD713689A5EEBBFAF8A4 "com.apple.systemdefault" (CSSMERR_TP_NOT_TRUSTED)
  2) D98B80C74D4D042D6524FE4413373962E675B79E "com.apple.kerberos.kdc" (CSSMERR_TP_NOT_TRUSTED)
     2 identities found
                                                Valid identities only
     0 valid identities found
  • building        target=macOS zip arch=x64 file=dist/OpenLens-6.0.0-latest.1659257326349.1659267010061-mac.zip
  • building        target=DMG arch=x64 file=dist/OpenLens-6.0.0-latest.1659257326349.1659267010061.dmg
  • rebuilding native dependencies  dependencies=node-pty@0.10.1 platform=darwin arch=arm64
  • rebuilding native dependency  name=node-pty version=0.10.1
  • packaging       platform=darwin arch=arm64 electron=15.5.7 appOutDir=dist/mac-arm64
  • building block map  blockMapFile=dist/OpenLens-6.0.0-latest.1659257326349.1659267010061.dmg.blockmap
  • file source doesn't exist  from=/Users/jkr/Downloads/lens/locales
  • skipped macOS application code signing  reason=cannot find valid "Developer ID Application" identity or custom non-Apple code signing certificate, it could cause some undefined behaviour, e.g. macOS localized description not visible, see https://electron.build/code-signing allIdentities=  1) DB18FD789312661372C9CD713689A5EEBBFAF8A4 "com.apple.systemdefault" (CSSMERR_TP_NOT_TRUSTED)
  2) D98B80C74D4D042D6524FE4413373962E675B79E "com.apple.kerberos.kdc" (CSSMERR_TP_NOT_TRUSTED)
     2 identities found
                                                Valid identities only
     0 valid identities found
  • building        target=macOS zip arch=arm64 file=dist/OpenLens-6.0.0-latest.1659257326349.1659267010061-arm64-mac.zip
  • building        target=DMG arch=arm64 file=dist/OpenLens-6.0.0-latest.1659257326349.1659267010061-arm64.dmg

  • building block map  blockMapFile=dist/OpenLens-6.0.0-latest.1659257326349.1659267010061-arm64.dmg.blockmap
  • building block map  blockMapFile=dist/OpenLens-6.0.0-latest.1659257326349.1659267010061-mac.zip.blockmap
  • building block map  blockMapFile=dist/OpenLens-6.0.0-latest.1659257326349.1659267010061-arm64-mac.zip.blockmap
✨  Done in 198.87s.

Example:

# cat latest-mac.yml
version: 6.0.0-latest.1659257326349.1659267010061
files:
  - url: OpenLens-6.0.0-latest.1659257326349.1659267010061-mac.zip
    sha512: W9vnFd8umiv9w3QaMunTxYYaxfilBntrsNh9hbPWuL/1jmhEHQEvLOQOMn5yQuPRY+ggdgMjCZ4LjQ7GCS6JIg==
    size: 170006739
  - url: OpenLens-6.0.0-latest.1659257326349.1659267010061-arm64-mac.zip
    sha512: EbwfQtJzznIfewKUWn8K387zCIdpKWr3ARDW6vgwvumEWkJWrBw5csNKx2c2P/XFFWxpGMYECT1nckRW1T/59Q==
    size: 170673335
  - url: OpenLens-6.0.0-latest.1659257326349.1659267010061.dmg
    sha512: TeczNljQ0nqd21oWyipTKYhb6Btjr325ZPkaY1fccIkKPtSfxtMVE/EJGdF7DEaRnTIsFpWUNwTmLnL95qY4Ig==
    size: 176265768
  - url: OpenLens-6.0.0-latest.1659257326349.1659267010061-arm64.dmg
    sha512: GvsM/7MzxQiXnjJW/4JHE4l6WuypegM1pz16W/v3Tfna2IqUyYObC3kQ5/jkfJ1nbh2nMP5F2DhsJlZyDqSfnA==
    size: 177257350
path: OpenLens-6.0.0-latest.1659257326349.1659267010061-mac.zip
sha512: W9vnFd8umiv9w3QaMunTxYYaxfilBntrsNh9hbPWuL/1jmhEHQEvLOQOMn5yQuPRY+ggdgMjCZ4LjQ7GCS6JIg==
releaseDate: '2022-07-31T11:38:40.731Z'

Closes #3 Closes #14

MuhammedKalkan commented 2 years ago

The dmg files are not copied to release assets. Check 6.0.0 assets please. There should be arm dmg file aswell