search

Muhao-Chen / Tensegrity_Finite_Element_Method_TsgFEM

Tensegrity_Finite_Element_Method(TsgFEM)
Mozilla Public License 2.0
14 stars 8 forks source link

[JOSS] Automated Tests #1

Closed HaoZeke closed 2 years ago

HaoZeke commented 3 years ago

Part of https://github.com/openjournals/joss-reviews/issues/3390.

It is necessary to include unit tests and instructions to run them; without which over time the maintainability of the software will suffer.

diehlpk commented 2 years ago

@Muhao-Chen Could you please have a look here as well?

diehlpk commented 2 years ago

@Muhao-Chen Could you please have a look here as well?

diehlpk commented 2 years ago

@Muhao-Chen Could you please have a look here as well?

diehlpk commented 2 years ago

@Muhao-Chen Could you please have a look here as well?

diehlpk commented 2 years ago

@Muhao-Chen Could you please have a look here as well?

Muhao-Chen commented 2 years ago

@HaoZeke Thanks for your comments! Please have a look at the Tensegrity_Finite_Element_Method_TsgFEM/Software_Verification_and_Examples/Dynamics_Examples/03_double_pendulum/ Tensegrity_Finite_Element_Method_TsgFEM/Software_Verification_and_Examples/Dynamics_Examples/05_T_bar_Dynamics/ These simple examples are given as unit tests. For the double pendulum example, we also compare the results with rigid body dynamics. We also updated the comments in the codes and descriptions. Thank you!

Muhao-Chen commented 2 years ago

@HaoZeke @diehlpk Thanks for pointing it out. We also updated the Tensegrity_Finite_Element_Method_TsgFEM/User_Guide/User_Guide_Tensegrity_Finite_ElementMethod(TsgFEM) .pdf As you may see, the unit tests examples, procedures, and results are described in detail in this pdf. Thank you!

diehlpk commented 2 years ago

@HaoZeke Please have a look at the new changes.

diehlpk commented 2 years ago

@HaoZeke Please have a look at the new changes.

HaoZeke commented 2 years ago

This has been resolved.