search

MukurtuCMS / Mukurtu-CMS

Mukurtu CMS v4 Development
20 stars 2 forks source link

Cultural protocols browse facet not properly handling content with multiple protocols. #499

Open michael-wynne-wsu opened 3 months ago

michael-wynne-wsu commented 3 months ago

I know @nick-deer and @jonscottwsu are aware of this.

Screenshot 2024-06-21 at 1 27 15 PM

jonscottwsu commented 3 months ago

Michael discovered communities (returning an array of communities) displays the facet(s) properly.

Looking at the related code to see if same/similar solution can be used in this case

nick-deer commented 3 months ago

@michael-wynne-wsu this is looking much more complicated than we bargained for... I looked at why community facets are correct but not protocols facets and that is because our protocols field is custom, (i.e., multiple protocols show up as a custom list of protocol ids) and facets don't know how to tease that out. The community facet, on the other hand, follows the out-of-the-box convention of entity->name and it seems facets DO know how to separate these correctly into unique facet results. I don't think it would be a good idea to force cultural protocols to follow that convention because that would likely upend a TON of code...

Sigh, so what I guess I'm saying is more digging and more time is needed to get the cultural protocol facet working as we want. We can keep working on it, just wanted to let you know it'll be a significant dev time sink. Should we keep going on this or move on?

michael-wynne-wsu commented 2 months ago

@nick-deer Hmm, how annoying!

On the upside, protocol facet is not currently in v3, so we're not losing functionality. That said I've implemented it for a handful of sites and it's a semi-common request, so I'm torn.

I think I'd like to keep this open, but feel free to move on to something else for the moment. We can discuss in an upcoming meeting.

@alexmerrill FYI