search

MukurtuCMS / Mukurtu-CMS

Mukurtu CMS v4 Development
20 stars 2 forks source link

Geofield #516

Closed michael-wynne-wsu closed 2 months ago

michael-wynne-wsu commented 3 months ago

https://www.drupal.org/project/geofield

michael-wynne-wsu commented 3 months ago

Unsure why we have it locked to an older version.

jonscottwsu commented 2 months ago

Nick updated and tested the geolocation (most recent version 1.59) and we did exploratory testing - all tested functionality appears to be working so far

michael-wynne-wsu commented 2 months ago

Awesome - is there anything you need me to look at to confirm?

jonscottwsu commented 2 months ago

Geofield was the 3rd module we have worked through the audit process together - I am trying to fully understand (and emulate) Nicks's dev process so we can divvy up the list and make some more headway asap.

This was one of the least complicated module audits so far and we have only done exploratory testing (imported data with geolocation data and created a new digital heritage item) on a local branch so the process of validating the (module) update is still under discussion.

michael-wynne-wsu commented 2 months ago

Yep, we’ll put this on the agenda!

michael-wynne-wsu commented 2 months ago

@jonscottwsu As we talked about, these are the things that I would do exploratory testing to check on Geofield status. And as noted, some of this obviously involves other modules...

  1. Migration. Does v3 location data migrate properly?
  2. Creation. Within a DH item (and/or any other content types that support mapping), do the following work as expected?
    • Point
    • Polygon
    • Line
    • Rectangle
    • MANY locations
    • Per-location descriptions (click on location to add)
  3. View. Do all the locations display properly on the content page AND the browse page? This includes overlapping areas, point clustering, location description tooltips.
  4. Edit. Does anything weird happen when the content is edited after being created? Eg: the location data shouldn't disappear!
  5. Export. Does the location data come out as expected when run through our export tools?
  6. Import. Does the location data work as expected when imported?
    • Updating content
    • Creating new content
nick-deer commented 2 months ago

@michael-wynne-wsu I made a test branch with the most current version of Geofield! I could get a Gitpod instance running on it with no issues. Let me know if it works for you:

https://github.com/MukurtuCMS/Mukurtu-CMS/tree/test-updated-geofield-module

michael-wynne-wsu commented 2 months ago

@nick-deer it all seems to be working as well as before, so I think you can include that in core and mark this module as up to date!