search

MukurtuCMS / Mukurtu-CMS

Mukurtu CMS v4 Development
20 stars 2 forks source link

Migrate media content warnings #553

Closed michael-wynne-wsu closed 1 month ago

michael-wynne-wsu commented 3 months ago

Dependent on completion of content warnings in v4 #126

michael-wynne-wsu commented 3 months ago

If nothing else, the trigger fields are now different (new "media tags" field)

nick-deer commented 2 months ago

@michael-wynne-wsu proof of concept is almost done, I'm just wrestling with twig templates! Expect something tomorrow

michael-wynne-wsu commented 2 months ago

@nick-deer awesome!

nick-deer commented 1 month ago

@michael-wynne-wsu okay so Twig was more complicated than I thought, but I am close! My JavaScript isn't working just yet, but I got the styling for the content warnings showing up on the media! More next week!

nick-deer commented 1 month ago

@michael-wynne-wsu @alexmerrill @jonscottwsu Alright guys media content warnings are finally up! It's a first pass so I expect it'll be janky someplaces, but it should be demoable! Let me know all your feedback and quirks you find with it (I am aware of some but I'm sure there are more).

Instructions for setting up content warnings should be in the mukurtu_content_warnings module README! Let me know if you have any trouble!

alexmerrill commented 1 month ago

Nice, I just took a peek! works as expected for me, looks like next step is to get the overlay on the browse modes too!

michael-wynne-wsu commented 1 month ago

Seconding Alex that this is working great, and I love how helpful the module read me is! A few notes as I was testing.

1) If possible, adding media tag terms on the fly from /admin/config/mukurtu/taxonomy/records would be a great user experience improvement. Including a link there to the media tags taxonomy would also be acceptable.

2) The read me does say that you need to use the "media tags" vocabulary for deceased warnings when it should actually be whichever field(s) are configured at /admin/config/mukurtu/taxonomy/records. To be clear, it works as expected, just a documentation error.

3) I suspect this is covered in other browse/view modes like Alex noted, but just in case, the warnings are not appearing at all when the multiple media carousel is active (more than one media asset in a field).

4) Message text should probably be white. Currently dark grey and hard to read on the black overlay.

5) I think we may want to adjust the placement and text size of the messages, but we can leave that for a themer too.