search

MukurtuCMS / mukurtucms

GNU General Public License v2.0
81 stars 36 forks source link

Redirect to Dashboard doesn't apply to all roles that have access to it #139

Open rtrvrtg opened 2 years ago

rtrvrtg commented 2 years ago

@mimicho and I have been investigating an issue with redirecting to the Dashboard when certain types of users log in to our Mukurtu instances, and we think this might be a minor inconsistency in Mukurtu's core.

Currently, the Homebox configuration allows three roles to view the Dashboard: administrator, Mukurtu Administrator, and Curator. https://github.com/MukurtuCMS/mukurtucms/blob/e98be0f8d1b4e89c20a3cc2591c5da35d7404c7a/sites/all/modules/custom/features/ma_dashboard/ma_dashboard.features.inc#L180

However, the hook_user_login implementation that Mukurtu provides only redirects to the dashboard for roles administrator and Mukurtu Administrator. https://github.com/MukurtuCMS/mukurtucms/blob/master/sites/all/modules/custom/features/ma_core/ma_core.module#L27

We should probably change the hardcoded roles, or change the hook to dynamically pull the list of supported roles from Homebox's configuration, unless there's a specific design reason why not all roles should be redirected to the dashboard.

taylor-steve commented 2 years ago

It looks like you are correct. Either solution is fine with me. If you want to do a PR (against develop, ideally) we're happy to accept it. Otherwise I'll probably alter the hardcoded roles at the time of next release. I'm not sure when that'll be, Mukurtu v3 is on security updates only currently as we've shifted all our dev efforts to the Drupal 8+ codebase. Thanks!