search

MukurtuCMS / mukurtucms

GNU General Public License v2.0
83 stars 36 forks source link

Apply soundcloud API patch #165

Open michael-wynne-wsu opened 5 months ago

michael-wynne-wsu commented 5 months ago

See here https://www.drupal.org/project/scald_soundcloud/issues/3248343

nick-deer commented 4 months ago

@michael-wynne-wsu finally applied it! I didn't have a Soundcloud client id and secret so I wasn't able to test it fully

michael-wynne-wsu commented 4 months ago

@nick-deer thanks!

And it uh looks like that might not actually be the thing we need. If you try to register an app through soundcloud it takes you to a broken form, so I really don't know what's up. I suspect/fear it will just be fully gone for v3... No idea about v4 and migration, we'll discuss in a dev meeting.

nick-deer commented 4 months ago

@michael-wynne-wsu That's a bummer... should I undo the patch so nobody gets confused by it?

michael-wynne-wsu commented 4 months ago

@nick-deer I hate to ask you to undo anything since I didn't vet the details in advance, but yeah...

nick-deer commented 4 months ago

@michael-wynne-wsu no worries, it was easy to undo. Pushed it!