MullinsLab / phylobook_pipeline

A program pipeline to run through multiple programs from sequence alignment fasta file to the resuts ready to publish on phylobook server
Other
1 stars 0 forks source link

Bug Report: Files with '.' in the name do not have full functionality #1

Open c-barry opened 8 hours ago

c-barry commented 8 hours ago

Bug Report: Files with '.' in the name do not have full functionality

Description:

Project files uploaded with '.' in the name are not functioning fully. While the files seem to be processed correctly (alignment and highlighter plot data files are generated as expected), there are specific issues:

Suspected Cause:

The issue seems to be related to how the URLs are constructed for files with '.' in their names.

Workaround:

This issue is not critical, as users can avoid it by ensuring that files are uploaded without additional periods ('.') in their names.

Steps to Reproduce:

  1. Upload a project file with an additional '.' in the filename (e.g., sample.file.fasta).
  2. Observe the following:
    • Annotation function is non-functional.
    • Highlighter plot is not displayed.

Expected Behavior:

Additional Context:

Files without extra periods in their names are functioning correctly.

PeterDarley commented 7 hours ago

It's not obvious to me why this would be happening. I suspect that the files that are being produced are misnamed for some reason, but I don't currently have a working install to test that on.

The simplest fix would be to update the handle_import_file() function in phylobook/projects/utils/general.py to replace extra periods with underscores.

Since this isn't considered critical it's probably best to mention this issue in the documentation and leave it until there is more active development on Phylobook.