search

Multarix / tera-guide-revised

A tera dungeon guide module - It features the spawning of objects and tts. Calls out boss mechanics and instructions.
Other
1 stars 0 forks source link

RE: Akalath Quarantine (3023.js) in/out mech doesn't appear to work #3

Closed Shiriko-star closed 4 years ago

Shiriko-star commented 4 years ago

Still getting the same issue with fresh install of your guide. I've confirmed that the latest commits were applied correctly but same problem. It doesn't always occur for every in/out (i.e. sometimes it works properly, or at least "OUT" does) but I've not had 1 Akalath Travan run where every in/out was signaled correctly.

Multarix commented 4 years ago

This is strange, the issue last time was due to the abnormal function. If you die it won't say anything.. Okay, question, does this happen with HSDN's guide too? If so I think I know the issue.

Multarix commented 4 years ago

this may or may not have been caused by me not passing mod through every sendMessage function... It seems fixed? Let me know, I can't get an IM party to test right now lol

Multarix commented 4 years ago

haha, I think you got caught with what it actually said. I changed the messages slightly to tell you what color was inside, if you feel that might be a bit to confusing I can change it back to the color that you're supposed to be standing on. image

Multarix commented 4 years ago

Okay sure thing, I'll change it back then. I'll close this for now, be sure to reopen it if the issue happens again. As far as I can tell there shouldn't be any more issues relating to it. We will see though! Also I hate to say it, but it's possible you had some lag spike. If that was the case, there is nothing I can do.

justkeepquiet commented 4 years ago

This problem is caused by the fact that your script does not have a hook to handle the event entry "ns-3023-1000", due to which the function firstboss_start_event() is not executed. You need to add a hook S_SPAWN_NPC or go back to the old entry, like "h-3023-1000-99".

Also look at the entry "ae-0-0-99020020", it needs proper handling of abnormals in this part of the code: https://github.com/Multarix/tera-guide-revised/blob/67fe66c493428b9ff40843fd52375c9fdb43c60a/modules/abnormals.js#L21

Multarix commented 4 years ago

Somewhat incorrect. debuff was already set to 0, so running the firstboss event was not an issue unless the party wiped, I just added the hp event back in the event your party for some reason wipes in AQ. On top of that, the abnormal key for the removal of the debuff is w/e. I added a death and ressurection event which works better imo.

justkeepquiet commented 4 years ago

A entries like "ae-0-0-99020020" is the old Michengs code (he didn't know about tera-game-state?). We also planned to get away from this by integrating events from the game-state. It's already done.