Fires not extinguished by collapsing wall

MultiAgentLearning / playground

PlayGround: AI Research into Multi-Agent Learning.

https://www.pommerman.com

Apache License 2.0

768 stars 216 forks source link

Fires not extinguished by collapsing wall #204

Closed suphoff closed 5 years ago

suphoff commented 5 years ago

Looks like the issue was overlooked at the last round of collapsing wall fixes.

Happy to submit a patch once I have my environment up and running again. (for verification)

weseldridge commented 5 years ago

I cannot remember what caused this, but in some cases, the playable board isn't removed. I remember seeing that during some of the playbacks in the competition.

suphoff commented 5 years ago

@weseldridge : Yeah - you probably observed this then - when the flames finally expire they are replaced by a passage. I tried to use collapsing walls to force a winner for learning - but with this bug agents frequently ended up walled in and isolated apart from each other.

weseldridge commented 5 years ago

Yup! That is it.

suphoff commented 5 years ago

Fixed by #205