MultiAgentLearning / playground

PlayGround: AI Research into Multi-Agent Learning.
https://www.pommerman.com
Apache License 2.0
765 stars 217 forks source link

Better Pommerman graphics #7

Closed weseldridge closed 6 years ago

weseldridge commented 6 years ago

I notice in the "How can I help?" section there is a topic of better graphics. I agree fully. This morning I started working on a sprite sheet. I am assuming to start we need sprits for each of the Item in the Item Enum Class?

I have started looking over the code that builds the board. It will need to be modified to support sprites. I haven't gotten into the implementation yet.

I will post the sprite sheet once I have a first decent copy of it.

cinjon commented 6 years ago

Cool, that would be awesome! Would gladly appreciate any help along this direction.

weseldridge commented 6 years ago

artboard 1

I am still working on the pommerman agents. Do you think this is getting closer?

cinjon commented 6 years ago

I really like how this is coming along. A couple thoughts:

  1. Can we change the shading on 7 (+ bomb) to be more different from 10 (skull)? I love that the other items are colored.
  2. Does it make sense to have the flames be more expansive and consequently look like it's the whole block?
weseldridge commented 6 years ago

I went back to the gold for the bomb coin. I can try another color if you would like to see the coin in a different color(s).

screen shot 2018-02-27 at 15 41 50 pm

I would really like to do something like this for the flames. However, the game runtime doesn't support it right now.

nes - bomberman - general sprites

I am not native to Python and do not know the libraries that the runtime use. I thought maybe in a future release we can have really good flames.

After saying all of that, I will create a couple more fire/explosion examples to see which works best.

cinjon commented 6 years ago

Ahh, I see what you mean. I agree that that would be nice to add, but I think we're both bandwidth constrained and would rather make agents :). Let's stay away from that complexity for now.

Sg! Thanks again for doing this. It's going to make it a lot better.

weseldridge commented 6 years ago

titles

Here is what I came up with for the agents. What are your thoughts? Sorry about them being all messed up. It is how they were exported...

weseldridge commented 6 years ago

Ok. I moved all the stuff from PS to illustrator. Still, need to redo the wood, but here is what I could do this afternoon. Getting closer!!

sprites

cinjon commented 6 years ago

!!! This is awesome. Have you tried changing the graphics to be these gorgeous sprites? I haven't yet thought through the proper way to do that.

weseldridge commented 6 years ago

I haven't yet. I am going to start that tomorrow and over the weekend. It will push some changes and get some feed back.

weseldridge commented 6 years ago

This is the start of the graphics update.

https://github.com/weseldridge/playground/commit/358cb4120d7064be7397c05f53466dfc49a305b3

weseldridge commented 6 years ago

I finished the wood tile and updated the dummy tile. Also worked on a couple of suggestions from the PR. A few more updates are still needed.

https://github.com/weseldridge/playground/blob/17127b6b8405a645c96e108c25cd74b4956c77b0/pommerman/envs/images/Sprites-03.png

https://github.com/weseldridge/playground/blob/17127b6b8405a645c96e108c25cd74b4956c77b0/pommerman/envs/images/Sprites-14.png

screen shot 2018-04-05 at 5 56 53 pm screen shot 2018-04-05 at 5 57 06 pm
weseldridge commented 6 years ago

@cinjon I changed the color of their helmets a little and gave each a different mouth. Do you think that is enough to help distinguish each player?

titles

cinjon commented 6 years ago

👍 ! It'd be nice to see them on the board, but from this vantage point, yes they do look more distinguished.

  1. Is the gray one the dummy?
  2. Is the bottom right one just there to show what it used to be?
  3. If it's still an issue when they're on the board, three possibilities: a. Color their mouth the color of their helmet b. A nose that's the color of their helmet. c. Expand the size of the colored part of their helmet by making the sides a little thinner to give room for bigger ear muffs.
weseldridge commented 6 years ago

The gray one is the dummy. The bottom right is b/c I am a lazy cropper. 😬

I am doing some db training stuff today. I will post the updated board in a bit. 👌

weseldridge commented 6 years ago

The top image is with the updated agents. The bottom one is for reference.

screen shot 2018-04-10 at 09 49 02 am

38442490-173f4420-39ae-11e8-818c-3b3577a3b222