search

MultiChat / Development

An advanced cross-server chat management system for Bungeecord
GNU General Public License v3.0
48 stars 26 forks source link

fix: add silence leave for premiumvanish #168

Open ChipWolf opened 3 years ago

ChipWolf commented 3 years ago

Description

What, briefly, is the purpose of this pull request?

Adds functionality to silence leave messages if the user is vanished with PremiumVanish.

Is this pull request related to an issue with the plugin?

Fixes #167

What is the status of this pull request? [e.g. In Development, Undergoing Final Testing, Ready]

Ready for merge

Changes

What currently existing parts of the plugin are affected by this pull request

If users vanish with PremiumVanish, it sends a fake leave message. If they then leave the server, there's another leave message. Users which are vanished with PremiumVanish cannot leave incognito.

What new features are added to the plugin by this pull request

An option to silence leave messages if a user is vanished with PremiumVanish.

Standards

Does this pull request adhere to basic Java coding standards?

I matched the standard of the existing code implemented to silence the join messages.

Does this pull request seem to stay true to the style used so far in the MultiChat code.

Yes, it's essentially a copy and paste job :)

ChipWolf commented 3 years ago

@OllieMartin ready for you to merge

ChipWolf commented 3 years ago

@Gadsee do you have merge access?