search

MultiCrew / copilot

Flight simulator shared cockpit organisation and dispatch tool
MIT License
3 stars 0 forks source link

Add logic to flight join trait #164

Closed hcphoon01 closed 3 years ago

hcphoon01 commented 3 years ago

Logic needs to be added to flight join trait to ensure that a single departure and single arrival airport are set before accepting request

calumshep commented 3 years ago

There's already logic to prevent a flight without a single dep and arr being dispatched. I personally think the steps of accepting a flight (and being matched with your copilot) and then discussing dep and arr airports before deciding on a single one for each, and then dispatching, is better; having to decide on a single dep and arr before the request has two pilots would require them discussing it with each other but they're not put in contact until they are on the flight request so it's like skipping a step - does that make sense?

hcphoon01 commented 3 years ago

Roger, I will need to update the API to comply with this logic

calumshep commented 3 years ago

Nice one GH

hcphoon01 commented 3 years ago

(Its not closed as its still in feature/api not been merged into dev yet)

calumshep commented 3 years ago

Can you open a PR for it pls