search

MultiMC / Launcher

A custom launcher for Minecraft that allows you to easily manage multiple installations of Minecraft at once
https://multimc.org/
Other
4.31k stars 883 forks source link

Globals settings and instance settings should use same UI fragments for overridable settings. #2029

Open Naheulf opened 7 years ago

Naheulf commented 7 years ago

System Information

MultiMC version: 0.5.2 and 0.6.0-develop-1089

Operating System: windows

Summary of the issue or suggestion:

Globals settings and instance settings should use same logic/file.

What should happen:

Only one logic should be used to group the global settings that can be customized in each instance. The reuse of certain "* .ui" files for the two displays should make it possible to avoid new oversights in the event of subsequent modifications. It should also reduce (a bit) the work needed to translate all strings on http://translate.multimc.org.

Steps to reproduce the issue:

  1. Open MultiMC.

  2. Select an instance or create a new instance.

  3. Open this instance settings.

  4. Select one tab in "Settings" menu.

  5. (optional) Return to step 2 and Select/create another instance. This allow to display another tab in another window.

  6. Moves (and resize) MultiMC windows. The main window must not cover instances settings windows.

  7. Open MultiMC global settings.

  8. Compare instances settings GUI with following global settings :

    • MultiMC>Console>Console Settings
    • Minecraft>Window Size
    • Java>Memory
    • Java>Java Runtime
    • Java>Custom Commands (and comment below)

Suspected cause:

Some partial code update

Logs/Screenshots:

differences

Additional Info:

I try help to translate MultiMC to french. I fund an old comment for custom commands and I see it's still use in global Custom commands.

peterix commented 7 years ago

Hmmm... alright. I bet I have it in the workflowy TODO list, at the very least for java configuration.

There's also a third place these can show up in - the initial setup wizard.