MultiMC / Launcher

A custom launcher for Minecraft that allows you to easily manage multiple installations of Minecraft at once
https://multimc.org/
Other
4.26k stars 874 forks source link

Instances with long names can cause the interface to reflow #2210

Open quat1024 opened 6 years ago

quat1024 commented 6 years ago

System Information

MultiMC version: 0.6.1-develop-1211 on win32

Operating System: Windows 7

Summary of the issue or suggestion:

Instances with very long names can cause the right panel of the MultiMC window to become abnormally large, which can cause other instances to shift in position and dance around the screen.

What should happen:

The instance name on the right panel should truncate or (preferably) line-break more often.

Steps to reproduce the issue (Add more if needed):

  1. Make a handful of instances.

  2. Give one a very long name.

  3. Click around on the different instances. You might have to play with the window size.

Logs/Screenshots:

Movie demonstration: https://gfycat.com/CandidNegativeGlowworm

Additional Info:

This normally wouldn't be that big of a deal (just don't make long instance names, dorp!), but if you download a .zip file from Curse and import it through MultiMC without changing any filenames, the default name MultiMC gives it is pretty long, which can cause the bug to appear without "trying to break it".

Also long names are incredibly funny and I demand multimc gets first class support for my shitty sense of humor.

peterix commented 6 years ago

Hmm...

  1. Replace the dashes with spaces, so it can actually flow normally?
  2. Somehow tell Qt that it can break after dashes and underscores?
phit commented 5 years ago

this does happen with spaces too https://phit.link/s/2018-11-23_12-28-23.webm it doesnt seem to break early enough

TheRandomLabs commented 5 years ago

This seemed too minor for a new issue, so I'll post it here. When there are letters like 'p' and 'g' in the instance name, their tails are partly cut off: image