search

MultiMC / Launcher

A custom launcher for Minecraft that allows you to easily manage multiple installations of Minecraft at once
https://multimc.org/
Other
4.28k stars 875 forks source link

Dragging and dropping a modpack zip into MultiMC from explorer resulted in explorer hanging for some time #2252

Open anpilley opened 6 years ago

anpilley commented 6 years ago

System Information

MultiMC version: 0.6.2-develop-1221

Operating System: Win10 16299.371

Summary of the issue or suggestion:

MultiMC supports dragging and dropping zipped up modpacks into its window to start the Add Instance process. Doing this from an explorer window hangs the explorer window until the import is complete, at which point, the explorer window becomes responsive again.

What should happen:

Explorer should remain responsive to user input.

Steps to reproduce the issue (Add more if needed):

  1. Download a larger modpack from curseforge.com (I was using Sevtech).

  2. Locate the modpack zip file in explorer.

  3. Drag the modpack into the MultiMC window.

  4. Attempt to interact with the originating explorer window.

Suspected cause:

Likely, the code stemming from https://github.com/MultiMC/MultiMC5/blob/604295e6d504f6e41ec2f91500479edbf2838a2d/api/logic/minecraft/ModList.cpp#L128 needs to be modified to queue up an import action, and then return to the drag/drop caller as quickly as possible, to release the drag&drop operation on Explorer's side.

Logs/Screenshots:

Additional Info:

peterix commented 6 years ago

Makes sense.

peterix commented 6 years ago

Fixed in develop (AFAIK)

anpilley commented 6 years ago

Yep, picked up the new build this morning, no more problems with explorer being unresponsive. Nice.

peterix commented 6 years ago

Glad to hear it. This was way worse with drag&drop of URLs from the browser :)

Zekken01 commented 6 years ago

Does this also fix the issue with chrome?

peterix commented 6 years ago

I believe so. I tested it on Windows 7 and the problem was gone.

Zekken01 commented 6 years ago

I can confirm fixed, I believe there may still be open issues related to this.

swoolcock commented 6 years ago

Note that Finder in macOS has the same freezing issue, but this change does not fix it.

peterix commented 6 years ago

@swoolcock are you sure you are using the develop builds when testing this?

swoolcock commented 6 years ago

Yes, using the latest develop build.

peterix commented 6 years ago

OK... needs further investigation.

anpilley commented 6 years ago

Yep. Can confirm it’s fixed on windows but not on my MacBook.