search

MultiMC / Launcher

A custom launcher for Minecraft that allows you to easily manage multiple installations of Minecraft at once
https://multimc.org/
Other
4.31k stars 883 forks source link

Crash when using large image for Modpack icon #2811

Open radiomike opened 5 years ago

radiomike commented 5 years ago

System Information

MultiMC version:

0.6.7

Operating System:

XFCE 4.14 or GNOME 3.32 on Arch Linux

Summary of the issue or suggestion:

When a large image is used as a mod-pack Icon, MultiMC crashes when starting "Edit Instance" dialog.

What should happen:

MultiMC shouldn't crash, edit Dialog should appear.

Steps to reproduce the issue (Add more if needed):

  1. Assign a large Image as a Mod-pack Icon. In My case I downloaded image for Enigmatica 2 from Curse, which was a 2362x2362 PNG.

  2. start "Edit Instance" or "Edit Notes" etc

  3. MultiMC stops

Suspected cause:

Image too big, or MultiMC not handling large image correctly.

Logs/Screenshots:

MultiMC-0.log

Additional Info:

This behaviour only started in 0.6.7. Was using same image in 0.6.6 and possibly 0.6.5 with no issue.

Obvious workaround is resizing image to something more appropriate. 256x256 seems to work.

peterix commented 5 years ago

Do not use such large images as icons?

radiomike commented 5 years ago

Perhaps, although only indication it was so large was that MultiMC crashed. Also it hadn't had issues with previous version.

As an aside, Enigmatica2 comes with a smaller icon as part of the modpack, would be a useful feature if MultiMC checked for icons when installing a pack from zip or twitch.

peterix commented 5 years ago

None of the curse packs come with icons. It's not part of the file format.

peterix commented 5 years ago

Anyway, icons above certain size (both in bytes and in dimensions) should not be loaded.