search

MultiMC / Launcher

A custom launcher for Minecraft that allows you to easily manage multiple installations of Minecraft at once
https://multimc.org/
Other
4.31k stars 883 forks source link

[Request] Deleted instances should go to the recycling bin #3193

Open aaronhowser1 opened 4 years ago

aaronhowser1 commented 4 years ago

System Information

MultiMC version: 0.6.11-1430

Operating System: W10

Summary of the issue or suggestion: When an instance is deleted, it should be sent to the recycling bin so it can be recovered

Heufneutje commented 4 years ago

Why? MultiMC asks you very clearly if you're sure you want to delete your instance. Aside from that it would have to be implemented separately for each OS. And not even all of them have recycle bins.

aaronhowser1 commented 4 years ago

Because some people are stupid might delete the wrong instance if they aren't paying attention, and it would prevent something like this

Heufneutje commented 4 years ago

It just adds an unnecessary extra step for everyone who does want to actually delete an instance, not to mention maintainability cost. All to solve a very niche use case that most games don't bother with either. If you delete a save file it's gone as well. I don't see this any differently.

Zetabite commented 4 years ago

I agree to @Heufneutje its just an extra hassle and I have nobody than myself to blame if I delete an instance. Yes it can happen by accident, but thats still my fault.

peterix commented 4 years ago

That's what backups are for.

But if I were to do this, I'd implement a 'recycle-bin-like' functionality in MultiMC, not use the system one. They are incredibly janky and unmanageable from within MultiMC.

JakeMoe commented 4 years ago

If this does get implemented (which I personally hope it doesn't), I hope it'd be a) a configurable option, and b) off by default. I certainly don't want this; I hard-delete everything in Windows, bypassing the Recycle Bin, so it doesn't clutter up my disk. In Linux, I mostly use the command line to delete, so it doesn't apply. And with modpacks (and all the mods inside them) taking up as much space as they do, that MultiMC recycle bin could get pretty big.

ProjectSynchro commented 4 years ago

Something like this could easily be an opt in feature, But seeing that an 'ARE YOU SURE' prompt comes up when you opt to delete an instance..

I don't really see why it would be needed.

codingJWilliams commented 4 years ago

The kind of people who opt in to that feature are not the same people that randomly delete instances they need without taking a backup. I don't see the point.

catronomix commented 1 year ago

Today I accidentally removed my main instance instead of a single screenshot because I thought I activated a windows Explorer window but I unknowingly focused the MultiMC window. Lost weeks of progress (years if I had not made a copy weeks ago which luckily I did). But still I was surprised that pressing delete and not shift+delete would skip the recycle bin!

Of course its a form of user error, but that's the whole reason for OS's to implement things like the recycle bin. Saying not every OS has that feature is a moot argument. It can easily be accounted for by calling the OS for the folder deletion operation, and from there on the operation will be performed in a way the user is familiar with.

Disk space issues that would arise by keeping the deleted instances should also be handled by the OS's cleanup features when applicable.

Bottom line is, making it super easy to delete someone's years upon years of creative progress without any chance to undo that action when it is technically possible to give it a chance is not the right choice when it's just to make a point along the lines of: "if you make an error it's your own fault".

Zetabite commented 1 year ago

If someone comes around implementing it in a way that makes sense and makes a PR, sure. But as of now, its as "wont fix"/"out of scope".

phit commented 1 year ago

dont put your faith into the recycle bin to keep anything you care about safe, drives die all the time or get destroyed, local and external backups!

catronomix commented 1 year ago

I'm not really a programmer, just some very basic knowledge. But from what I find out from searching this repo, the GUI is using this QT framework, for which the documentation lists this function: QFile::moveToTrash() which I guess is supposed to use the trash when the OS supports it?

malino-dev commented 1 year ago

I've just had a case where I deleted an instance without knowing the worlds are gone too. Should have known since I looked at the folder structure before but guess I just didn't. But the worst part is that I seemingly can't even use file recovery software to get my backup (which MMC has created because of a version switch) back. So I don't know what's going on here that even this software can't find the *.zip file. But to actually contribute to this issue: a possible solution would be to at least have backupped worlds to not be deleted when deleting an instance.