search

MultiMC / Launcher

A custom launcher for Minecraft that allows you to easily manage multiple installations of Minecraft at once
https://multimc.org/
Other
4.3k stars 884 forks source link

Adding uncompressed resource packs via the instance editor #3225

Open depwl9992 opened 4 years ago

depwl9992 commented 4 years ago

Some artists have been known to distribute resource packs uncompressed and unarchived in a folder, and this is supported by the engine. However, MultiMC's "Add" feature in the Resource Packs section of the instance editor only allows addition of ZIP and JAR files.

The most straightforward solution I can think of is to allow this is to add the file extension .mcmeta to the Add Resource Pack dialogue and on that filetype copy the entire parent folder with its contents into an instance's resourcepacks folder.

Zetabite commented 4 years ago

Distributing packs uncompressed is a bad practice and should not be condoned.

peterix commented 4 years ago

But what about working on them?

Zetabite commented 4 years ago

What you mean, elaborate

peterix commented 4 years ago

That when you are working on one of those, it's easier to work with the exploded version of it, rather than a packaged one.

Working with folders is easy. You can init a git repo in there, version the resource pack and it's in general, nice.

I'd rather go in the direction of supporting this better than not.

Zetabite commented 4 years ago

Maybe not directly importing uncompressed, but having a parameter in the meta to decompress it. Would also be nice feature for importing worlds.

QuImUfu commented 4 years ago

And there seems to be a bug in Minecraft that some packs doesn't work in compressed form, but work as folder. (e.g. Faithful 1.15)

foul-fortune-feline commented 2 years ago

There's also a bug related to this: If you put an uncompressed resource pack in manually attempting to copy the instance fails consistently