search

MultiMC / Launcher

A custom launcher for Minecraft that allows you to easily manage multiple installations of Minecraft at once
https://multimc.org/
Other
4.29k stars 877 forks source link

multimc -d folder deletes all files in the folder #3257

Closed ghost closed 4 years ago

ghost commented 4 years ago

System Information

MultiMC version: 0.6.11

Operating System: Linux 5.7.8 (NixOS)

Summary of the issue or suggestion:

multimc -d folder is listed as --dir but actually means --delete.

What should happen:

0.000 D <> Log initialized.
0.002 D <> Error: folder 'folder' contains misc files.
< Multimc exit >

Steps to reproduce the issue (Add more if needed):

  1. mkdir folder

  2. touch folder/file.txt

  3. multimc -d folder

  4. ls folder # file.txt is deleted

Janrupf commented 4 years ago

Eh? You know... it changes the installation home of MultiMC, which MultiMC then cleans up to get it ready for working. No --delete at all, it is --dir. There could maybe be a notice that it cleans the folder, but its 100% intended.

peterix commented 4 years ago

There is no such functionality anywhere in the codebase.

Where did you get this version of MultiMC, who made it, and how can I contact them?

peterix commented 4 years ago

This is most likely also a license violation.

Zetabite commented 4 years ago

https://github.com/jD91mZM2/nixpkgs/blob/master/pkgs/games/multimc/default.nix its not a licsense violation, they redistribute the official mmc build, but they add some stuff on nix site by adding flags

peterix commented 4 years ago

Looks like a build from source to me... Maybe the wrapper messes things up?

Zetabite commented 4 years ago

I dont think it messes up, it does stuff intentionally, but then again, i am not a nix user

ghost commented 4 years ago

Oh wops, I should have checked that first. Thought it was a builtin option. Seems it's added with a wrapper. wrapProgram $out/bin/multimc --add-flags "-d \$HOME/.multimc/" --set GAME_LIBRARY_PATH /run/opengl-driver/lib:${libpath} --prefix PATH : ${jdk}/bin/:${xorg.xrandr}/bin/