search

MultiMC / Launcher

A custom launcher for Minecraft that allows you to easily manage multiple installations of Minecraft at once
https://multimc.org/
Other
4.32k stars 883 forks source link

stop creating "coremods" folder #3348

Open UpcraftLP opened 4 years ago

UpcraftLP commented 4 years ago

When creating and launching a new instance in MultiMC, there will be a coremods folder inside. This folder is created for ANY instance, even vanilla ones (or for other mod loaders like Fabric).

This folder hasn't been needed by Forge ever since 1.6.1, and now, 7 years later, it's just unused bloat.

Would it be possible to simply not create it for instances that are newer than 1.5.2 (or 1.6.1 if you really care about those few alpha builds of forge)?

Zetabite commented 4 years ago

AFAIK that would need a whole new system to be implemented on waht is stored in the version info are stored. MMC doesnt diffrentiate between pre and post 1.6.1, but some other versions. There are more important stuff to fix than just not creating an empty folder. It is a few bytes at best, and since one barely looks into the instance folder, isnt a big issua visually wise

UpcraftLP commented 4 years ago

since one barely looks into the instance folder

Users probably don't, but when I am working on modpacks I do very often. Sure there are more pressing matters, but still worth having this issue imo, so that it can be implemented at some point in the future.

Zetabite commented 4 years ago

Yeah, just wanted to let you know that this is probably very low prio on any list

HassaFelipe commented 4 years ago

since one barely looks into the instance folder

Users probably don't, but when I am working on modpacks I do very often. Sure there are more pressing matters, but still worth having this issue imo, so that it can be implemented at some point in the future.

You can set core/API/lib mods as occult and then configure the folder for don't display occult files.

This way, you don't have to worry about them anymore and they continued to work.

HassaFelipe commented 4 years ago

When creating and launching a new instance in MultiMC, there will be a coremods folder inside. This folder is created for ANY instance, even vanilla ones (or for other mod loaders like Fabric).

This folder hasn't been needed by Forge ever since 1.6.1, and now, 7 years later, it's just unused bloat.

Would it be possible to simply not create it for instances that are newer than 1.5.2 (or 1.6.1 if you really care about those few alpha builds of forge)?

Sorry I went through this, but you can still do it with the "coremods" folder but you will need to copy the instances to keep this configuration.

UpcraftLP commented 4 years ago

You can set core/API/lib mods as occult and then configure the folder for don't display occult files.

This way, you don't have to worry about them anymore and they continued to work.

WHat do you mean by "occult"? Do you mean hidden folders? Yes, that is one option, but each OS handles that differently (UNIX systems often require folder names to start with a dot, which would of course no longer be the same name)

Also, hiding these folders isn't the issue, imo they should not be created in the first place, since they serve no purpose in modern Minecraft installations (see my original comment).