Add ability to set java settings override for each group

EnderMelody commented 3 years ago

System Information

MultiMC version: 0.6.11-1430

Operating System: windows 10

Summary of the issue or suggestion:

Add an option for groups to allow java settings that override the general settings set for Multimc, but gets overridden by settings set in the pack's settings. Having a modded group that auto sets the ram would be very helpful.

9p4 commented 3 years ago

Related: #3608

Forkk commented 3 years ago

This does sound like a really nice feature to have, but given the way groups are currently implemented, this could require a lot of redesigning.

Xetaxheb commented 3 years ago

Basically implementing a presets system for settings menu somewhere to quickly swap to various configurations (Global 1, Global 2, etc); while still allowing for checkbox based profile specific overrides

I don't think making "groups" do anything like this inherently is a good idea, and should be kept to UI organization exclusively, but the several-presets system could solve (aka make fast and easy) the question of having different sets of generalized settings

One step further could be

adding a line to instance.cfg's that is either a unix timestamp of installation or a random UUID to use for pack identifiers instead of the folder/pack literal name (in places like instgroups.json)
a new instpreset.json file in /instances/ where instpreset.json tells that a pack is using a preset different from the basic global one; instead of saving it to instance.cfg and potentially causing import/deleted preset issues (especially when sharing exported packs to friends).... leaving instance.cfg clean to store checkbox overrides

LiDucky commented 2 years ago

Pitching in my two cents as well! It'd be nice to be able to set a java path for each instance, which if not set defaults to the overall settings. I play on several different versions and have to change the java path each time I swap from 1.17.1 to 1.8.9 or 1.18.

9p4 commented 2 years ago

@LiDucky You can set the Java path for each instance already. This issue is for setting the Java instance / settings for groups.

Go to Edit Instance -> Settings (sidebar) -> Java Installation

LiDucky commented 2 years ago

Oh, awesome! I'll see if I can find it! Would you like me to remove my previous comment as it's not relevant?

9p4 commented 2 years ago

It's better to have a log of everything than to remove it.

MultiMC / Launcher

Add ability to set java settings override for each group #3657

System Information

Summary of the issue or suggestion: