MultiMC / Launcher

A custom launcher for Minecraft that allows you to easily manage multiple installations of Minecraft at once
https://multimc.org/
Other
4.29k stars 877 forks source link

Automatically detect the java version each Minecraft version needs upon instance creation. #4013

Open Ekain06 opened 3 years ago

Ekain06 commented 3 years ago

Role

I want to create 1.17+ instances as well as playing modpacks and such.

Suggestion

I want MultiMC to automatically assign the correct java version for each instance at creation.

Benefit

So that I don't need to fiddle with settings when creating a new instance, and so that new users don't get confused when Minecraft doesn't launch.

This suggestion is unique

You may use the editor below to elaborate further.

MultiMC can already detect the different JREs installed including each's version. Using this and the newly added "javaVersion" key to the vanilla version JSONs, I suppose it wouldn't be too difficult to implement. (I don't know MultiMCs codebase so I could be wrong here)

MythicBlade commented 3 years ago

I think this is an amazing Idea this is something that has messed me up before

ghost commented 3 years ago

i like this idea, and i feel like it could in theory be easy to implement, but its minor imo

Zetabite commented 3 years ago

Its not minor if it is one of the main reasons of people having issues with MMC

barraIhsan commented 2 years ago

Yes, I agree!

zaphod77 commented 2 years ago

for that matter, it should

a) search in the "c:\program files (x86)\Minecraft\Runtimes" for java versions, under the assumption that you probably have the original native launcher, and it's probably there. (this is the easy one) b) if it doesn't find them there, it should make a java subdirectory under the install folder and go grab the needed java version from microsoft directly if it doesn't match the detected system version.

Many other alternative launchers are quite capable of doing this very stunt, and the ability to auto-download java is a very good way to make the launcher much more usable for noobs.

Ekain06 commented 2 years ago

@zaphod77 I think that's a different issue. MultiMC can already detect installed java versions (not the official launcher's, though) and I suggested that it automatically chose the right one for the instance version using that functionality. What you are suggesting is a way for MultiMC to automatically find / download java. I think you should open another thread.

jredfox commented 2 years ago

yes but edit it to be optional. like auto select the recommended jvm, then have it automatically download to a path you give it. this is to prevent it from being actually installed interfering with the main jvm of the end user's main java installation. for example minecraft indev was written in java 5(? if not earlier) but you can run it on java 8 without issues and java 8 fixed alot of issues between those times.

cootshk commented 12 months ago

do it sort of like the modrinth launcnher does

https://github.com/PrismLauncher/PrismLauncher/issues/1720 (see the screenshot)

ascpial commented 6 months ago

This is even more needed as mojang added yet another version of java to support.