search

MultiMC / Launcher

A custom launcher for Minecraft that allows you to easily manage multiple installations of Minecraft at once
https://multimc.org/
Other
4.26k stars 874 forks source link

Confirm on mod deletion #4751

Open MissPotato opened 2 years ago

MissPotato commented 2 years ago

Role

Modpack Development

Suggestion

When clicking "remove" or the shortcut on "del" in the loader mods tab confirm input

Benefit

Save me from myself

This suggestion is unique

You may use the editor below to elaborate further.

When I was trying to enable a selection of mods, I misclicked and hit Remove instead. This deleted all the selected mods without asking if I actually wanted this to happen. This doesn't mimic the behavior of selecting "delete" to delete instances. When doing that, a popup appears titled "CAREFUL!", tells you what you're about to delete, warns you that it is completely deleting the instance, and also selects the no button by default.

Other solutions are to move the remove button so it's not right next to enable, move the mods to the trashcan instead of deleting, or only have remove be a right click option.

loustact commented 2 years ago

Better if a CTRL + Z feature is also added to undo the deletion.

TacoGS commented 2 years ago

It probably wouldn't be hard to implement a confirmation of deletion feature. However, an undo deletion would require we do something like staging the file for deletion and then eventually delete it when sufficient time passes. Otherwise we are at the mercy of the OS and some weird form of undelete.