MultiMC / Launcher

A custom launcher for Minecraft that allows you to easily manage multiple installations of Minecraft at once
https://multimc.org/
Other
4.31k stars 883 forks source link

MMC deleting profile on failed auth. #5474

Closed Shadefang closed 3 months ago

Shadefang commented 3 months ago

Operating System

Windows

Description of bug

Upon trying to launch an instance I was given a message to refresh my minecraft account. Doing so failed, as it appears minecraft's auth servers are currently down. When it failed, the profile was removed from the list.

I would expect MMC upon receiving a "service unavailable" response from the auth servers to at very least retain the existing profile, and hopefully allow for launching offline.

Steps to reproduce

I would assume attempting to log in (or possibly refresh) an account while the auth servers are down. This is not something I have the capabilities of testing repeatedly as the profile no longer exists and I can't create a new one, as the auth servers are down.

Suspected cause

No response

This issue is unique

Talon-1 commented 3 months ago

Same problem, this is the 2nd time my account poofed from auth server issues, I too wish I could at least launch my single player worlds while auth is down.

HoneyPS commented 3 months ago

Im having the zac same issue i tried chaning my login from codes to my number to my finger print and still haunted by the error to access token. Screenshot 2024-07-19 105010

DarianLStephens commented 3 months ago

Exact same problem just happened to me. I had launched the game just fine a few hours ago, but now it's apparently expired, and wanted me to log in again with Microsoft. I did, then it failed to get the access token and deleted my account from the list.

iiPythonx commented 3 months ago

Xbox services regarding login are currently offline: https://support.xbox.com/en-US/xbox-live-status. You're gonna have to wait for them to come back online.

Shadefang commented 3 months ago

Xbox services regarding login are currently offline: https://support.xbox.com/en-US/xbox-live-status. You're gonna have to wait for them to come back online.

I'm aware they're down, and that that's why I'm having access issues. There's a reason my issue isn't just "I can't access my game" and instead is "Trying to access the game while the auth servers were down deleted my profile."

iiPythonx commented 3 months ago

Just realized the issue title, my bad. I guess it would be smart for the launcher to keep the existing profile but regardless it's still going to require a re-login with Xbox services since the sessions have been invalidated.

Shadefang commented 3 months ago

somewhat fair, assuming the sessions were invalidated by something other than the fact the servers are down. Frankly, if the servers are unreachable, and you're on an account that was previously authorized it should just let you launch offline.

phit commented 3 months ago

Duplicate of https://github.com/MultiMC/Launcher/issues/5078

Shadefang commented 3 months ago

Duplicate of #5078

Should I bring up the additional problem in that issue thread? That in addition to not working offline the profile gets deleted (which also means the suggested proxy workaround won't work, as there's no profile to launch offline)

phit commented 3 months ago

the account removal is intentional and was added with https://github.com/MultiMC/Launcher/pull/4998, obviously it shouldnt happen in case of server issues though