MultiPaperK8s / MultiPaperImages

Multipaper Images
MIT License
6 stars 4 forks source link

FEATURE: Add curl dependency to container for automated plugin pulling #12

Closed Matthew-Beckett closed 2 years ago

Matthew-Beckett commented 2 years ago

This is a dependent PR for https://github.com/MultiPaperK8s/MultiPaperKustomize/pull/1

RemcoSpigot commented 2 years ago

Lgtm, but let’s separate concerns and only add curl to the image and target this PR for master branch.

Matthew-Beckett commented 2 years ago

Please remove the GitHub action change and target merge into master instead

Doing so would also merge experimental/aarch64 into master and that is not part of this PR.

RemcoSpigot commented 2 years ago

Please remove the GitHub action change and target merge into master instead

This on top of moving this PR to target experimental/multi-os. Or feel free to add the code directly into this branch :) Approved as it's not going to impose any risk other than users downloading wrong packages themselves during initialisation.