search

MultiSafepay / Magento2Msp

MultiSafepay plugin for Magento 2 (Deprecated) see: https://github.com/MultiSafepay/magento2
Open Software License 3.0
29 stars 25 forks source link

Added execution of order_cancel_after event when cancelling the order. #125

Closed egordm closed 4 years ago

egordm commented 4 years ago

When an order is cancelled in multisafepay, the order_cancel_after is not triggering which in turn causes some other modules not handing the order cancellation (properly). This is likely done to circumvent the order service which calls "$this->getPayment()->cancel();". This commit adds manual dispatching of this event like $order->cancel() does.

vinodsowdagar commented 4 years ago

Hi @EgorDm ,

Thanks for your PR,

The change seems to be correct. We will let you know as soon as possible when we are done confirming and testing this change.

Jasper-MultiSafepay commented 4 years ago

@EgorDm We cannot find a good reason why there was a circumvention of $this->getPayment()->cancel(); So we have merged a PR which is using $order->cancel() instead of manual dispatching events