MultiSafepay / Magento2Msp

MultiSafepay plugin for Magento 2 (Deprecated) see: https://github.com/MultiSafepay/magento2
Open Software License 3.0
29 stars 25 forks source link

Order cancellation event #131

Closed egordm closed 3 years ago

egordm commented 4 years ago

In the last release code is updated to run the cancel call in order to emit the order cancellation events. (pr https://github.com/MultiSafepay/Magento2Msp/pull/125 and c8c14431094e7f56fb94f4e025f758f55f7e2edb) There are still a few parts of the code that handle cancellation the previous way. Is it possible to apply a similar fix there too? Parts in question: https://github.com/MultiSafepay/Magento2Msp/blob/a63122083ddbc33bcf220691193a0b9d2c0b47ed/Controller/Fastcheckout/Cancel.php#L117 https://github.com/MultiSafepay/Magento2Msp/blob/0ca7cb37860ca5e41259c879fc2d272077f5dbb7/Model/Connect.php#L1306 and the ones below (4 occurences)

Thanks in advance.

Ronald-MultiSafepay commented 4 years ago

@EgorDm
Thank you for reporting. We have created an internal task for this report and will try to review as soon as possible. Internal reference: PLGMAGTWOS-669

Stanislau-MultiSafepay commented 3 years ago

Hi! @EgorDm

Unfortunately, this plugin is deprecated and we are not providing support for it anymore. Please, upgrade to our New Magento 2 plugin.

This issue has not occurred in the new plugin and the new plugin also has tons of other improvements.

I am closing this issue for now. If you have any more comments or questions, feel free to create a new issue in the new plugin repository.