Fix Shipment.php $shipped boolean

MultiSafepay / Magento2Msp

MultiSafepay plugin for Magento 2 (Deprecated) see: https://github.com/MultiSafepay/magento2

Open Software License 3.0

29 stars 25 forks source link

Fix Shipment.php $shipped boolean #141

Closed Asitis closed 3 years ago

Asitis commented 4 years ago

$shipped is a boolean, it can't be checked as array.

nocturnalfrog commented 3 years ago

It seems to me like the shipOrder function also needs to be refactored so it always returns a boolean. Right now it returns sometimes true, sometimes an array.

vinodsowdagar commented 3 years ago

Hi @Asitis ,

Thank you for your contribution.

We have added a fix for this in the latest release already. Please be aware that this was the last thing we picked up for this repo as it is now deprecated and will not receive any more updates. Please upgrade to our New Magento 2 plugin.

For now i will close this PR as the fix has already been merged.