search

MultiSafepay / Magento2Msp

MultiSafepay plugin for Magento 2 (Deprecated) see: https://github.com/MultiSafepay/magento2
Open Software License 3.0
29 stars 25 forks source link

Only use `$shipping` if not empty #50

Closed jissereitsma closed 6 years ago

jissereitsma commented 6 years ago

In the Connect class line 333 (https://github.com/MultiSafepay/Magento2Msp/blob/master/Model/Connect.php#L333) a reference to $shipping->getStreetLine() is made. However, when a product is not a Simple Product but a Virtual Product, shipping is not involved and hence $shipping is empty. There should be a if check if $shipping is empty.

jissereitsma commented 6 years ago

Reference https://github.com/MultiSafepay/Magento2Msp/pull/51

JonkRuud commented 6 years ago

@jissereitsma thanks for reporting, we already had this one fixed internally and will push this to Github probably tomorrow/beginning next week.

JonkRuud commented 6 years ago

@jissereitsma slight delay in pushing, but the current dev version has a fix for this one, so will close this issue.

jissereitsma commented 6 years ago

Cool. thanks for the update!