search

MultiSafepay / Magento2Msp

MultiSafepay plugin for Magento 2 (Deprecated) see: https://github.com/MultiSafepay/magento2
Open Software License 3.0
29 stars 25 forks source link

Make sure $shipping is never empty #51

Closed jissereitsma closed 7 years ago

jissereitsma commented 7 years ago

Reference https://github.com/MultiSafepay/Magento2Msp/issues/50

JonkRuud commented 7 years ago

@jissereitsma we have this fixed in the next released in a different way. In your proposal assigning the billing data to the shipping data won't be a good solution because when using for example Klarna or Pay After Delivery this would be wrong data used on the invoices and for the fraud checks.

So we have created a validation using $order->canShip() before we are using and adding shipping data to the transaction request.