search

MultiSafepay / Magento2Msp

MultiSafepay plugin for Magento 2 (Deprecated) see: https://github.com/MultiSafepay/magento2
Open Software License 3.0
29 stars 25 forks source link

Fatal error RestoreQuote #60

Closed rikwillems closed 6 years ago

rikwillems commented 6 years ago

After the last update to 1.4.8 I get the following error. Disabling the Keep cart alive feature doesn't help.

Fatal error: Uncaught Error: Call to a member function getMethodInstance() on null in vendor/multisafepay/magento2msp/Model/Observers/RestoreQuote.php on line 6

Jasper-MultiSafepay commented 6 years ago

@rikwillems This part of the code was already in place since 1.4.6 and could be caused by the session not being available. Could you send an email to techsupport@multisafepay.com ? We would like to investigate this further.

rikwillems commented 6 years ago

When I replace the 1.4.8 code with the 1.4.7 code in the execute method of the RestoreQuote observer it works again. The added code does make a incompatible change.

Jasper-MultiSafepay commented 6 years ago

Unfortunately we cannot reproduce this on our test environments. Would it be possible if we investigate this further on your environment? If so, could you send an email to techsupport@multisafepay.com ?

rikwillems commented 6 years ago

After accidentally updating the module again my problem is back. Can you please review this code change?

Jasper-MultiSafepay commented 6 years ago

We have done our code reviews and testing and cannot find any issues. Would it be possible if we investigate this further on your staging environment? If so, could you send an email to techsupport@multisafepay.com ?

rikwillems commented 6 years ago

Thank you Jasper, I've sent you an email.

Jasper-MultiSafepay commented 6 years ago

Should be solved with 1.4.9