search

MultiSafepay / Magento2Msp

MultiSafepay plugin for Magento 2 (Deprecated) see: https://github.com/MultiSafepay/magento2
Open Software License 3.0
29 stars 25 forks source link

Compile error in version 1.5.1 #73

Closed GuidoHub closed 6 years ago

GuidoHub commented 6 years ago

Errors during compilation: MultiSafepay\Connect\Model\Connect Incorrect dependency in class MultiSafepay\Connect\Model\Connect in /xxx/xxx/xxx/xxx/public_html/app/code/MultiSafepay/Connect/Model/Connect.php \Magento\Framework\App\State already exists in context object Total Errors Count: 1

Jasper-MultiSafepay commented 6 years ago

@GuidoHub We are investigating this. On which version of Magento2 are you encountering this?

GuidoHub commented 6 years ago

@jasper-multisafepay It's on magento 2.1.14

Jasper-MultiSafepay commented 6 years ago

Can reproduce this. Being caused by context validation in Magento 2.1.x This context validation is removed in Magento 2.2.x Have added a solution to the current sprint of the plugin. Sprint will be finished at the end of this month. If needed I could make that branch public, so you can use the fix?

GuidoHub commented 6 years ago

@jasper-multisafepay , would be nice if you could make it public so I can use the fix.

Jasper-MultiSafepay commented 6 years ago

@GuidoHub Pushed branch 28c583645c33bee6cacfd451ec1eefcae7ed9016 for this compilation fix. Will be added to the current sprint

hostep commented 6 years ago

@jasper-multisafepay: wouldn't it make sense to release a hotfix where you include this fix, so a new version 1.5.2 with only the inclusion of this fix (if it is tested properly)? I can imagine a lot of people updating to 1.5.1 running into this problem now. And waiting a full month for a fix is maybe a bit much?

(We haven't update ourselves yet, so I can't say if it will happen to us, but it sounds like it will when we do this on our Magento 2.1.x shops)

Thanks!

Jasper-MultiSafepay commented 6 years ago

@hostep I'll have to discuss this internally if that's possible

GuidoHub commented 6 years ago

@hostep I think you should also look at this issue #74

Jasper-MultiSafepay commented 6 years ago

@hostep I have received feedback on your request for a hotfix release: The timing between a seperate hotfix release and the current sprint would be too short as it includes more extensive testing. The next version (which also includes fixes for #73, #74) will be released no later than 21-9.

hostep commented 6 years ago

Ok no problem, we'll hold of the upgrade for now on our 2.1 shops then. Thanks for the feedback!

Jasper-MultiSafepay commented 6 years ago

We released 1.6.0 which solves this issue.