search

MultiSafepay / Magento2Msp

MultiSafepay plugin for Magento 2 (Deprecated) see: https://github.com/MultiSafepay/magento2
Open Software License 3.0
29 stars 25 forks source link

Observe 'create shipment' and 'place order' globally #87

Closed evs-xsarus closed 5 years ago

evs-xsarus commented 5 years ago

Currently, when a shipment is created or an order is placed, those events are only observed when it happens in the adminhtml. If these events are thrown in the frontend, or in command line scripts, the observer isn't triggered.

Could you release a new version where these observers are changed so they are triggered regardless of the frontname the event is thrown in?

I.e.: move https://github.com/MultiSafepay/Magento2Msp/blob/master/etc/adminhtml/events.xml to https://github.com/MultiSafepay/Magento2Msp/blob/master/etc/events.xml

JonkRuud commented 5 years ago

@evs-xsarus Thank you for your proposed change, we will create an internal task for this to review and test. If all is working we will add this to the release

Jasper-MultiSafepay commented 5 years ago

PLGMAGTWOS-365

evs-xsarus commented 5 years ago

@Jasper-MultiSafepay could you give me an estimate when this review will be performed?

Ruud-MultiSafepay commented 5 years ago

@evs-xsarus This task is part of our current sprint and is already resolved internally, pending a release.

evs-xsarus commented 5 years ago

Thank you for the feedback, I'll await the release.

Jasper-MultiSafepay commented 5 years ago

We have released 1.7.0 which solves this issue.