Prevent sending an order confirmation when an order is cancelled/expired

[basvanpoppel]

Issue

Customers are receiving order confirmation emails when a transaction is expired:

• The transaction was started by the customer
• The customer didn't finish the transaction (therefor does not receive an order confirmation)
• After a month the transaction expired
• The client received the order confirmation email from Magento.

Conditions:

• Magento v2.4.*
• multisafepay/magento2 v2.7.1
• Setting "Send the order confirmation email" is set to "After transaction"

Cause:

When Multisafepay send a notification to Magento, the function "processOrderTransaction" is called. This tries to send an order confirmation straight away, but does not check the transaction status.

Fix:

Check transaction status before sending the order confirmation.

ps. due to lack of time I have not (yet) written tests along with this PR. However I do hope this PR is of use for you.

[vinodsowdagar]

Hi @basvanpoppel ,

Thank you for your contribution. We will internally test this and add it to the next release.

[vinodsowdagar]

Hi @basvanpoppel ,

We just created a new release where we included this fix: https://github.com/MultiSafepay/magento2-core/releases/tag/2.6.0

Since the fix has already been merged and released, we will close this PR. As a thank you for your contribution we want to send you our newly designed t-shirt. Can you tell us via e-mail to which address we can send your gift and what your shirt size is? You can send the e-mail to integration@multisafepay.com and my colleagues will pick it up.