search

MultiSafepay / magento2-core

Provides core functionalities
Open Software License 3.0
2 stars 10 forks source link

Set the order status by calling their respective functions #17

Closed indykoning closed 2 years ago

indykoning commented 2 years ago

Currently orders are canceled twice after the addition of configurable order statuses, this is because $order->setStatus() has no checks wether the order is already canceled.

In MSI this means duplicate cancel reservations will be made.

The cancel function on the order itself already has the necessary checks built in to prevent this.

vinodsowdagar commented 2 years ago

Hi @indykoning ,

Thank you for the PR, we will look into it and come back to you later.

vinodsowdagar commented 2 years ago

Hi @indykoning ,

We are having trouble with reproducing this issue. For me the order_canceled reservation is only happening once like it should: image

To my understanding, changing the status of the order should not have effect on the order state itself right? Perhaps you can show step by step how to reproduce it and how to measure the double cancel reservations, so we can have a clear view on how to reproduce this.

Right now i am also not sure if we are even understanding the issue correctly, so some more clarification would help a lot.

danielcivit commented 2 years ago

Hi @indykoning,

After two months, we didn't get a reply to the questions made on this PR. We are closing this PR due inactivity. Please, feel free to reopen it, if you are available to provide more information.