Fix for TypeError in ShipmentSaveAfterObserver

MultiSafepay / magento2-core

Provides core functionalities

Open Software License 3.0

2 stars 10 forks source link

Fix for TypeError in ShipmentSaveAfterObserver #2

Closed davekleijn closed 3 years ago

davekleijn commented 3 years ago

We get the following error on our production environment: "TypeError: Return value of MultiSafepay\ConnectCore\Observer\ShipmentSaveAfterObserver::getTrackingNumber() must be of the type string, int returned".

Our client is using different shipping providers with different tracking numbers. Some tracking numbers do not contain letters. This PR is fixing this issue.

Stanislau-MultiSafepay commented 3 years ago

Hi @Davie82

Thank you for the contribution. We will internally review this and come back to you later.

vinodsowdagar commented 3 years ago

Hi @Davie82 ,

We have internally reviewed and merged your change already. It is available in the latest version of the module: https://github.com/MultiSafepay/magento2-core/releases/tag/2.8.1

I heard you already talked to @Berend-MultiSafepay about the contribution gift. We will send it to you soon :)

davekleijn commented 3 years ago

Thanks @Vinod-MultiSafepay!