MultiSafepay / magento2-core

Provides core functionalities
Open Software License 3.0
2 stars 10 forks source link

Null customer ID when requesting guest payment url #20

Closed Jade-GG closed 1 year ago

Jade-GG commented 1 year ago

This function throws an error when attempting to retrieve a payment url when checking out as guest, because int is not nullable by default.

vinodsowdagar commented 1 year ago

Thanks @Jade-GG , we will look into this as soon as possible and come back to you later.

Jade-GG commented 1 year ago

To give some extra context on this, we found this issue when trying to do the following REST API call:

[API BASE URL]/multisafepay/[guest cart ID]/payment-url/[order ID]

If you do this call, an error occurs in the backend and the stack trace can be tracked back to where I applied this patch.

It works fine when logged in, because the API call is different:

[API BASE URL]/multisafepay/mine/payment-url/[order ID]
vinodsowdagar commented 1 year ago

Hi @Jade-GG , we've confirmed the issue and your PR as a solution.

We will add it in the next release. As soon as we have released it, i will let you know.

royduin commented 1 year ago

Any updates?

vinodsowdagar commented 1 year ago

Hi @royduin and @Jade-GG ,

We have released a new version of the module with the fix in it: https://github.com/MultiSafepay/magento2/releases/tag/2.23.0

I'm closing this one for now, if you have more questions or comments, feel free to add a comment here or create a new PR.

royduin commented 1 year ago

Great, thanks!