Fix float comparison with incompatible types

MultiSafepay / magento2-core

Provides core functionalities

Open Software License 3.0

2 stars 10 forks source link

Fix float comparison with incompatible types #3

Closed reense closed 3 years ago

reense commented 3 years ago

The $amount variable is casted to a float on line 70. Strict checking a float with 0 will always resolve to false. See: http://sandbox.onlinephpfunctions.com/code/33d898e211ecf37ae50872b37b26549d3e7c7930

I've also added a missing return statement in MultiSafepay\ConnectCore\Model\Method\GenericAdapter and i've removed a redundant check in MultiSafepay\ConnectCore\Service\OrderService.

vinodsowdagar commented 3 years ago

Hi @reense ,

Great observation. We are going to look into this and come back to you after we have internally reviewed it.

vinodsowdagar commented 3 years ago

Hi @reense ,

We have internally reviewed and merged your PR already. It is available in the latest release: https://github.com/MultiSafepay/magento2/releases/tag/2.10.2

Your contribution gift has been sent and i am closing this PR.