[BUGFIX] Prevent error when Shipping Description is null

MultiSafepay / magento2-core

Provides core functionalities

Open Software License 3.0

2 stars 10 forks source link

[BUGFIX] Prevent error when Shipping Description is null #4

Closed florisschreuder closed 3 years ago

florisschreuder commented 3 years ago

When the Shipping Description is null, Multisafepay will error on creating the transaction and invoice for the order. Meaning the order will be paid, but will stay on 'Pending Payment' (and eventually be cancelled) in Multisafepay.

There are several reasons why ShippingDescription might be empty - in our case, we change shipping after order-save. But Magento does not actually have a 'hard' requirement on shipping description, so there might be many cases where shipping description is empty.

vinodsowdagar commented 3 years ago

Hi @florisschreuder ,

Thank you for your contribution.

We will look into this and let you know when we have reviewed it internally.

vinodsowdagar commented 3 years ago

Hi @florisschreuder ,

I am closing this PR, because we already have reviewed and merged it internally. It is available from the latest release: https://github.com/MultiSafepay/magento2/releases/tag/2.11.0

I see that we already send you the contribution gift. You should receive it soon, if you haven't received it already.