search

MultiSafepay / magento2-graphql

MultiSafepay GraphQL module for Magento 2
Open Software License 3.0
7 stars 2 forks source link

Feature: Support Redirect payment type #7

Open indykoning opened 1 month ago

indykoning commented 1 month ago

We are in the process of migrating payment methods from using Magento's rest API to using GraphQL in our checkout. Frontend-wise we cannot migrate without forcing our user to also use Payment components even though payment type is set to redirect. image

This is because https://github.com/MultiSafepay/magento2-graphql/blob/master/Model/PaymentAdditionalDataProvider.php#L66 forces these parameters to also be filled without checking for payment type of the payment provider

It would be a nice solution to check wether the payment type before checking the additional data that's sent as that would not be necessary if it's redirect.

vinodsowdagar commented 2 weeks ago

Hi @indykoning ,

Thank you for the request, we are going to look into it and come back to you later.

indykoning commented 1 week ago

Above are 2 PRs that attempt to solve this behaviour in 2 different ways as it is not only the redirect option that suffers from this. Hopefully they'll help looking into it