search

MultiSafepay / magento2

MultiSafepay plugin for Magento 2
Open Software License 3.0
19 stars 8 forks source link

Validate API key button uses default store view always #26

Closed thlassche closed 2 years ago

thlassche commented 2 years ago

Describe the bug Pressing validate API key always yields a check for store id = 0 instead of the storeview of the current selected scope

To Reproduce Steps to reproduce the behavior:

  1. Leave API key on default store view empty
  2. Go to a non default storeview configuration
  3. Enter a valid API key
  4. Click validate API key
  5. Error is shown stating the API key is invalid

Expected behavior The API key is shown as valid

Cause https://github.com/MultiSafepay/magento2-adminhtml/blob/master/Controller/Adminhtml/Api/Validate.php#L87 is using a store_id parameter, but that parameter is not passed here: https://github.com/MultiSafepay/magento2-adminhtml/blob/master/Block/Adminhtml/Config/ValidateApiKeyButton.php#L72

vinodsowdagar commented 2 years ago

Hi @thlassche ,

Good observation, it seems to be correct. We will look into this and let you know more as soon as we have figured it out.

vinodsowdagar commented 2 years ago

Hi @thlassche ,

We have fixed this issue in our latest release: https://github.com/MultiSafepay/magento2/releases/tag/2.16.0

I am closing this issue. If you still have questions or comments, feel free to reopen this.