MultiSafepay / magento2

MultiSafepay plugin for Magento 2
Open Software License 3.0
18 stars 8 forks source link

Latest versions are no longer compatible with Magento 2.3.x (SecureHtmlRenderer) #55

Closed hostep closed 1 year ago

hostep commented 1 year ago

Describe the bug The latest versions of this module use a class Magento\Framework\View\Helper\SecureHtmlRenderer which was introduced in Magento 2.4.0 and didn't exist yet in 2.3.x

This leads to crashes in Magento 2.3.x shops.

To Reproduce

  1. Install Magento 2.3.6-p1
  2. Install this MultiSafepay module at version 3.1.1
  3. Run bin/magento setup:di:compile

Expected behavior No errors

Actual output

$ bin/magento setup:di:compile
Compilation was started.
Area configuration aggregation... 5/8 [=================>----------]  62% 47 secs 240.0 MiB
In ClassReader.php line 43:

  Class Magento\Framework\View\Helper\SecureHtmlRenderer does not exist

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

vinodsowdagar commented 1 year ago

Hi @hostep ,

Thanks for this one, i created a backlog item for it already. I'll let you know when we have looked into it a bit more.

vinodsowdagar commented 1 year ago

Hi @hostep ,

We've confirmed the issue and will make the fix available in a new release. We'll keep you informed.

vinodsowdagar commented 1 year ago

Hi @hostep ,

We've introduced a new release where this issue has been fixed: https://github.com/MultiSafepay/magento2/releases/tag/3.1.2

I'm closing this issue for now. Please add a new comment if there are any related comments and we will reopen this if needed.