discrepancies in the versions of the dependencies in the package.json file

[MartineBoulanger]

I'm getting an error about Invariant Violation, I want to integrate MultiSafepay in my PWA Studio project, which is still on version 10. In the documentation it states I just have to switch branches when I have cloned the repository. I switched with git checkout compability-v10, but when I checked the package.json it still has this:

"@magento/peregrine": "~12.1.0",
"@magento/pwa-buildpack": "~11.0.0",
"@magento/venia-ui": "~9.1.0",

While my package.json has this:

"@magento/pwa-buildpack": "~10.0.0",
"@magento/peregrine": "~11.0.0",
"@magento/venia-ui": "~8.0.0",

Shouldn't switching the branches also change the package.json?

[danielcivit]

Hi @MartineBoulanger

Thanks for your comments, and feedback. We will look into this.

In a first and quick view, the package.json file from our plugin seems wrong. Yes. But yours is not what we expect for PWA Studio 10 version either.

====

Here are those packages of PWA Studio 10.

pwa-buildpack: "9.0.0" https://github.com/magento/pwa-studio/blob/v10.0.0/packages/pwa-buildpack/package.json#L3C7-L3C22

magento/venia-ui: "7.0.0" https://github.com/magento/pwa-studio/blob/v10.0.0/packages/venia-ui/package.json#L3C4-L3C19

magento/peregrine: "10.0.0" https://github.com/magento/pwa-studio/blob/v10.0.0/packages/peregrine/package.json#L3

It's been a while since we've worked on this plugin, and maybe we're wrong. Do you have any other opinions about the packages corresponding to PWA Studio 10?

====

Could you share with us, the full error message you are getting?

[MartineBoulanger]

Hi! I'm sorry I was mistaken in the PWA Studio version I am working on, which is actually 11 and not 10 it seems, but still the package.json from the branch for v11 is also wrong.

Since I have been doing custom things for the checkout before, I have noticed that this integration is not working, so I had to merge some of the code from this repo into my project's code, and now it is working.

I'm sorry I could not be of more help now 😕 But it would be good to look at the package.json from all versions anyway.

[danielcivit]

Thanks again for your feedback @MartineBoulanger

We will look into this, hopefully during the next sprint, and get back to you after that to provide an answer.

[danielcivit]

@MartineBoulanger

Do you agree and could you consider changing the title of this GitHub issue to something related to the discrepancies in the versions of the dependencies in the package.json file; instead of "Getting Invariant Violation"?

It's just it seems to me, now we are talking about something else. And any user reading or following this repository might feel lost when found this ticket.

[MartineBoulanger]

@danielcivit Done!