search

Multibit-Legacy / multibit-hd

Deprecated Bitcoin Wallet
https://multibit.org/blog/2017/07/26/multibit-shutdown.html
Other
172 stars 114 forks source link

Create PR for BIP44 support work for Bitcoinj #441

Open gary-rowe opened 9 years ago

gary-rowe commented 9 years ago

The BIP44 support work is currently held in our Bitcoinj-Alice fork. It would be better if this work could be generalised and pushed upstream for other projects to benefit from.

This is a complex change and may require a lot of support work before a PR would be accepted upstream. For this reason it has to occur after the first release of the project.

devrandom commented 9 years ago

I have a general implementation that allows a DKC to have an arbitrary account derivation path. Should I'll compare my implementation to yours and see which one makes more sense to create a PR out of?

(Cc @mikehearn)

jim618 commented 9 years ago

It sounds similar. I found the serialisiing and deserialising of the wallets to be the least general part of the bitcoinj-alice code - not really good enough for a general purpose library.

devrandom commented 9 years ago

Yes, I had the same experience, due to the use of static functions. Ended up with some factory classes to generalize.

devrandom commented 9 years ago

Created https://github.com/bitcoinj/bitcoinj/pull/339